Skip to content

add isVisible typos and missing tests #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2018
Merged

add isVisible typos and missing tests #464

merged 2 commits into from
Mar 12, 2018

Conversation

saintplay
Copy link
Contributor

note that isVisible.TODO.js file

@eddyerburgh
Copy link
Member

Are you planning on adding isVisible.TODO in this PR?

@saintplay
Copy link
Contributor Author

yes!, if you allow me :)

@eddyerburgh
Copy link
Member

Yes definitely 😄

@saintplay
Copy link
Contributor Author

done

eddyerburgh
eddyerburgh approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😀

@eddyerburgh eddyerburgh merged commit 18eb193 into vuejs:dev Mar 12, 2018
@dennythecoder dennythecoder mentioned this pull request Mar 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saintplay @eddyerburgh